New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a new version? #63
Comments
Agreed, thanks for reminding me, although those changes all look quite minor, except the rename from VRFOutput to VRFPreOut impacts downstream crates. I should probably add
I'd wanted to rewrite musig.rs too, or really pull in all isis' much nicer version from https://github.com/isislovecruft/frost-dalek/ but maybe this could be yet another version. |
It would be great to also bump |
I'll switch to https://github.com/zkcrypto/curve25519-dalek-ng too. lol |
Ping! I'm still waiting for a version in order to in turn publish a version of smoldot on crates.io. |
Done! Thanks! :) |
@burdges was switching to curve25519-dalek-ng the right call in hindsight? should we switch back - there seems to be more contributors to the original crate... |
I suppose dalek-cryptography/merlin#63 says either works really.. I think neither is perfectly maintained, and we should not require either one's changes, but whatever.. I've noticed ng miss a couple good changes but nothing overly relevant here. I've now forgotten which changes though. A priori, I'd stick with HdV's versions since he is the one who knows elliptic curves. Anyways.. We've replaced ed25519-dalek with ed25519-zebbra because ed25519-dalek continually got batch verification wrong. And ed25519-zebbra presumably switched. |
The latest version has been published back in March 2020, around 10 months ago.
The diff is starting to be quite substantial: 156b84d...master
The text was updated successfully, but these errors were encountered: