Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new version? #63

Closed
tomaka opened this issue Jan 21, 2021 · 7 comments
Closed

Publish a new version? #63

tomaka opened this issue Jan 21, 2021 · 7 comments

Comments

@tomaka
Copy link

tomaka commented Jan 21, 2021

The latest version has been published back in March 2020, around 10 months ago.
The diff is starting to be quite substantial: 156b84d...master

@burdges
Copy link
Collaborator

burdges commented Jan 21, 2021

Agreed, thanks for reminding me, although those changes all look quite minor, except the rename from VRFOutput to VRFPreOut impacts downstream crates. I should probably add

#[deprecated(
    since = "0.9.2",
    note = "Please use VRFPreOut instead of VRFOutput"
)]
pub type VRFOutput = VRFPreOut;

I'd wanted to rewrite musig.rs too, or really pull in all isis' much nicer version from https://github.com/isislovecruft/frost-dalek/ but maybe this could be yet another version.

@tomaka
Copy link
Author

tomaka commented Feb 1, 2021

It would be great to also bump merlin to 3.0.0. Apparently there were no breaking changes apart from using a different version of rand.

@burdges
Copy link
Collaborator

burdges commented Feb 3, 2021

I'll switch to https://github.com/zkcrypto/curve25519-dalek-ng too. lol

@tomaka
Copy link
Author

tomaka commented Feb 24, 2021

Ping! I'm still waiting for a version in order to in turn publish a version of smoldot on crates.io.

@burdges
Copy link
Collaborator

burdges commented Feb 25, 2021

Done! Thanks! :)

@gilescope
Copy link
Contributor

@burdges was switching to curve25519-dalek-ng the right call in hindsight? should we switch back - there seems to be more contributors to the original crate...

@burdges
Copy link
Collaborator

burdges commented Oct 14, 2021

I suppose dalek-cryptography/merlin#63 says either works really..

I think neither is perfectly maintained, and we should not require either one's changes, but whatever.. I've noticed ng miss a couple good changes but nothing overly relevant here. I've now forgotten which changes though. A priori, I'd stick with HdV's versions since he is the one who knows elliptic curves.

Anyways..

We've replaced ed25519-dalek with ed25519-zebbra because ed25519-dalek continually got batch verification wrong. And ed25519-zebbra presumably switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants