[feat] Add GoodDollar whitelist

[julienbrg]

No description provided.

[Shloyem]

IdentityV2 as seen in GD documentation or Github is the contract in charge of managing whitelisted addresses.
isWhitelisted(address) returns a bool if yes or no.
In the GD contracts docs it directs to Identity contracts deployed on Mainnet, Fuse (Old Fuse), and Celo.

[bertux]

Let's investigate https://github.com/GoodDollar/GoodProtocol/blob/master/releases/deployment.json by looking at networkId fields

[julienbrg]

Let's do Celo Mainnet first: https://celoscan.io/address/0xC361A6E67822a0EDc17D899227dd9FC50BD62F42#readProxyContract#F19 (from @bertux's link)

[Shloyem]

The code change will be like in GD claiming contract UBIScheme.sol Claim function previous version
require( IIdentity(nameService.getAddress("IDENTITY")).isWhitelisted(msg.sender), "UBIScheme: not whitelisted" );

It was manually checked to work, and new UBIScheme claim is not needed - it checks if sender isWhiteListed or Identity contract itself, and holds root for further root actions
address whitelistedRoot = IIdentityV2(nameService.getAddress("IDENTITY")) .getWhitelistedRoot(msg.sender); require(whitelistedRoot != address(0), "UBIScheme: not whitelisted");

Moving on from here

[julienbrg]

The code change will be like in GD claiming contract UBIScheme.sol Claim function previous version require( IIdentity(nameService.getAddress("IDENTITY")).isWhitelisted(msg.sender), "UBIScheme: not whitelisted" );

Yes, exactly.

It will work fine on whatever network where we actually have a GD whitelist availaible. @bertux @Shloyem What can we do for other networks and tests?

[julienbrg]

@Shloyem We mentioned this one with @bertux today: we'll just optimize for Celo and Fuse, basically forget about testnets, and get inspired by GD best practices for the unit tests.

[Shloyem]

As we later discussed on Telegram, it's first tested on Celo Alfajores testnet with mocks:
gCFA with the change -> That uses NameServiceMock -> That uses IdentityMock (allows to add or remove addresses from whitelist easily).

1. Attempt to call gCFA.depositFor would revert with "Fail with error 'UBIScheme: not whitelisted'"
2. Whitelisted my address on IdentityMock
3. Approved the amount on EURMock
4. gCFA.depositFor passed

Next thing I'll check on Celo either Mainnet or simulate via Tenderly

[julienbrg]

From what I saw on this branch 10-feat-add-gooddollar-whitelist, we probably want to:

• rebase from main branch
• add a CELO_NAMESERVICE_ADDRESS in the .env.example file and in the deploy.ts script

@Shloyem Do you want me to do that + create a draft merge request?

[julienbrg]

@Shloyem @bertux Also, I had a question for you guys: how would a user get whitelisted, please?

[julienbrg]

Deployed to Alfajores:

• EURMock: 0x6bd981edf241d252b48af662a52e9d3ca84cdfae
• IdentityMock: 0x4A5C7e56a2e2E6641934522885e843e1dc98fC1f
• NameServiceMock: 0xAbf302bbe78f3e285dA4a7278DE428Caca96A873
• gCFA: 0x868cD4404e990746C07E99Eeb7328F2e8B09fa4C
• DAO: 0x020b796c418c363be5517c6febff5c5a9248f763

1st successful deposit: 0x7a311b27ce78e6e235a2c159e7fbcfbcc636b410374ac4204fa8029454bf3dec

[Shloyem]

From what I saw on this branch 10-feat-add-gooddollar-whitelist, we probably want to:

• rebase from main branch
• add a CELO_NAMESERVICE_ADDRESS in the .env.example file and in the deploy.ts script

@Shloyem Do you want me to do that + create a draft merge request?

Good ideas, done on draft pull request

[Shloyem]

@Shloyem @bertux Also, I had a question for you guys: how would a user get whitelisted, please?

As far as I understand:

1. Register to GoodDollar 2. Undergo it's face verification, so that no one user could claim with multiple account 3. Collect once in the last 30 days or so

Pros:

• Use an existing working mechanism
• "Forcing" users to enter the GoodDollar ecosystem, where besides gCFA they can also daily collect, transfer, convert, use tokens.

Cons:

• Will need to introduce both gCFA idea and GoodDollar idea to new users.

But again this is my personal take, @bertux knows better:)

[julienbrg]

Are we sure we need a setNameService function? Right now anyone can change the value of the nameService address, and that could make the deposit function unaccessible. @bertux Do we remove it or do we make it settable only by the DAO?

About this, we can just add a require in the setNameService function:

require(msg.sender == recoveryAddress, "Requires a community vote");

[julienbrg]

@Shloyem @bertux Also, I had a question for you guys: how would a user get whitelisted, please?

As far as I understand:

1. Register to GoodDollar 2. Undergo it's face verification, so that no one user could claim with multiple account 3. Collect once in the last 30 days or so

Thanks for your reply!

I'm definitely in favour of it. There's already a link pointing to GoodDapp claim (https://gooddapp.org/#/claim) in gCFA UI. But I need to know how can the UI detect if a user is whitelisted or not?

Upcoming version of the UI: https://gcfa-ui-staging.on.fleek.co/

@Shloyem I'm displaying this "You're currently not whitelisted, we need a Proof-of-Liveness which you can get here." but I need to call the isWhitelisted function to display correct info, right?

[Shloyem]

@Shloyem @bertux Also, I had a question for you guys: how would a user get whitelisted, please?

As far as I understand:

1. Register to GoodDollar 2. Undergo it's face verification, so that no one user could claim with multiple account 3. Collect once in the last 30 days or so

Thanks for your reply!

I'm definitely in favour of it. There's already a link pointing to GoodDapp claim (https://gooddapp.org/#/claim) in gCFA UI. But I need to know how can the UI detect if a user is whitelisted or not?

Upcoming version of the UI: https://gcfa-ui-staging.on.fleek.co/

Thanks for your replies as well, nice work

@Shloyem I'm displaying this "You're currently not whitelisted, we need a Proof-of-Liveness which you can get here." but I need to call the isWhitelisted function to display correct info, right?

Good idea, yes, described in the other item

[julienbrg]

We need to:

• Fix prettier (start with removing the prettier file)
• Add the whitelist tests in the tests
• Fix the ABI format: there should be a .abi file (json format)

[bertux]

We need to:

• Fix prettier (start with removing the prettier file)
• Add the whitelist tests in the tests
• Fix the ABI format: there should be a .abi file (json format)

Let's focus on the first 2 points, the other can be improved later, it's already the same in the UI.