Merge pull request #79 from w3nl/feature/quality-density

Test the quality and density
w3nl · Jul 25, 2024 · edb3717 · edb3717
2 parents 471e0b9 + b9b0a5a
commit edb3717
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ppt-png",
-    "version": "2.1.1",
+    "version": "2.1.2",
     "description": "Convert ppt to image (png,jpg)",
     "files": [
         "src/converter.js",

diff --git a/src/__tests__/converter.test.js b/src/__tests__/converter.test.js
@@ -23,8 +23,8 @@ test('PPT-PNG converter test', async (t) => {
             output: 'output/',
             options: {
                 density: 300,
-                quality: 100
-            }
+                quality: 100,
+            },
         });
 
         const result = converter.convert();
@@ -33,6 +33,8 @@ test('PPT-PNG converter test', async (t) => {
             result[0].file.path,
             'output/OPW 733 Tienduizend redenen.pdf'
         );
+        assert.strictEqual(converter.density, 300);
+        assert.strictEqual(converter.quality, 100);
         assert.strictEqual(
             fileExists('output/OPW 733 Tienduizend redenen.pdf'),
             true

diff --git a/src/converter.js b/src/converter.js
@@ -15,6 +15,8 @@ class Ppt2PngConverter extends Converter {
     constructor() {
         super();
         this.files = [];
+        this.density = null;
+        this.quality = null;
     }
 
     /**
@@ -67,8 +69,8 @@ class Ppt2PngConverter extends Converter {
         converter.setFiles(files);
         converter.setOutput(output);
 
-        converter.density = (options && options.density) || undefined;
-        converter.quality = (options && options.quality) || undefined;
+        converter.density = options?.density;
+        converter.quality = options?.quality;
 
         return converter;
     }