Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add comments to the code #298

Open
scotthibbs opened this issue Mar 21, 2024 · 1 comment
Open

Please add comments to the code #298

scotthibbs opened this issue Mar 21, 2024 · 1 comment
Labels
feedback Feedback to help us improve

Comments

@scotthibbs
Copy link
Collaborator

Send us feedback

NamasenITN wrote me on youtube, "I would love to join forces! Do you have or will have or could have a code-base walk-through?" I could not figure out the math for the frequency-domain emulation of atmospheric noise and honestly got lost in the original code base that had not a single comment."

As you move through the code of this program, take a second to comment what each section does.

@scotthibbs scotthibbs added the feedback Feedback to help us improve label Mar 21, 2024
@w7sst
Copy link
Owner

w7sst commented Mar 21, 2024

I have been adding comments to the code as I learn/understand the existing code base and when writing new code. I have always believed that comments in the code serve a good purpose and should explain the big picture of what it is doing and why. The original MR code was lacking comments, so adding them will only help future developers/coders to understand this code base. I will continue to add comments over time.

I have also added some UML (Unified Modeling Language) diagrams showing the overall design. This work can be extended further as time allows.

I will continue to add comments as I go along. In fact, it may be a good idea just to make a pass through the code and document the main control flow and perhaps the audio path (describe how the audio is generated once the simulation has started). I think both of these would be beneficial.

Other ideas:

  • Others should also be encouraged to add comments as they go.
  • We should reach out to Alex, the original author, to see if he has any old design documents or notes that he might be able to share with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Feedback to help us improve
Projects
None yet
Development

No branches or pull requests

2 participants