Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging @foxglove/avl upstream? #46

Open
jhurliman opened this issue Sep 14, 2021 · 6 comments
Open

Merging @foxglove/avl upstream? #46

jhurliman opened this issue Sep 14, 2021 · 6 comments

Comments

@jhurliman
Copy link

I just released the @foxglove/avl package to unblock waiting on some of the open PRs to this repo to merge, implementations of new functions such as findLessThan[OrEqual], findGreaterThan[OrEqual], cleaning up the naming convention to look more like ES6 containers such as Map<K, V> and Set<K>, and porting to TypeScript. Is there interest in merging this code into this repo and the avl package? If so, I can deprecate the @foxglove/avl package and direct users here. I'm also happy to continue maintaining @foxglove/avl if you'd prefer to keep the existing codebase.

@w8r
Copy link
Owner

w8r commented Sep 14, 2021 via email

@w8r
Copy link
Owner

w8r commented Sep 14, 2021

I'll be waiting for a PR, appreciate your contribution

@w8r
Copy link
Owner

w8r commented Sep 27, 2021

@jhurliman do you still want to do it?

@jhurliman
Copy link
Author

@w8r yes apologies, I'm just now returning from holiday. I will start preparing a PR this week.

@w8r
Copy link
Owner

w8r commented Sep 27, 2021

great! Let me know if you need help

@jhurliman
Copy link
Author

Apologies for the delay, see #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants