Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character counter seems to be one action behind #31

Closed
ScottW65 opened this issue Oct 15, 2013 · 5 comments
Closed

Character counter seems to be one action behind #31

ScottW65 opened this issue Oct 15, 2013 · 5 comments

Comments

@ScottW65
Copy link

Seems the character counter is counting based on the previous state of the content of the RTE, not the current state.

For example I'm typing in the word "testing" into an empty instance, one letter at a time. After the "t", it shows zero - after "te", one - up to six for the seven-letter word "testing". If I then select-all, the counter shows seven.

Deleting the selected text, the counter still shows seven, until typing again whereupon the counter returns to zero, despite there being a character present.

@w8tcha
Copy link
Owner

w8tcha commented Oct 16, 2013

Did you downloaded the plugin from github or from ckeditor.com. the one on here is newer (because i didnt release a new version until all issues are fixed).

I can not reproduce this issue with the latest version. Can you try it with the updated plugin.js?

@ScottW65
Copy link
Author

The plugin.js file from here works fine! Both with the issue above and the other one re: not counting HTML tag characters until you perform another action.

Considering CKSource is distributing this plugin when folks download CKEditor, might be good to get this change into that mix sooner than later. Also might add a version number into the plugin.js file somewhere so it's easier to check if one has outdated code.

@w8tcha
Copy link
Owner

w8tcha commented Oct 20, 2013

Also might add a version number into the plugin.js file somewhere so it's easier to check if one has outdated code.

Yes i will do that

@mmoats
Copy link
Contributor

mmoats commented Dec 18, 2013

This still wasn't working for me inside my angular directive. change the event 'key' to 'change' instead and it'll update on change instead.

@mmoats
Copy link
Contributor

mmoats commented Dec 18, 2013

Pull-Request Link: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants