Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook addon #53

Merged
merged 4 commits into from Sep 11, 2020
Merged

Storybook addon #53

merged 4 commits into from Sep 11, 2020

Conversation

Lelchik
Copy link
Collaborator

@Lelchik Lelchik commented Sep 11, 2020

No description provided.

@wKich
Copy link
Collaborator

wKich commented Sep 11, 2020 •
edited

  • Add babel config for build addon
  • Add addon preset and define webpack config with define plugin and pass custom creevey port. Use that port in CreeveyClientApi

wKich
wKich reviewed Sep 11, 2020
View reviewed changes
src/client/CreeveyView/ResultsPage/ResultsPage.tsx
Comment on lines +17 to +19
export const VIEW_MODE_KEY = 'Creevey_view_mode';

const getViewMode = (): ImagesViewMode => {
export const getViewMode = (): ImagesViewMode => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this to separate file

@wKich wKich changed the base branch from master to storybook-addon September 11, 2020 16:35
@wKich wKich merged commit 50f1ee4 into creevey:storybook-addon Sep 11, 2020
@wKich wKich mentioned this pull request Sep 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wKich wKich wKich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lelchik @wKich