Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subdomain type using ghday start date & end date is not the same as locale #328

Closed
ChiaYuSu opened this issue Mar 3, 2023 · 2 comments
Closed

Comments

@ChiaYuSu
Copy link

ChiaYuSu commented Mar 3, 2023

I don't know if it's because I didn't set locale: 'zh-tw' in date is not set to locale: 'zh-tw', so the problem is caused by
start date is not start at 2022/01/01, is start at 2022/01/02
image

But if I set loacle: 'zh-tw' console, the following problem occurs
image

@wa0x6e
Copy link
Owner

wa0x6e commented Mar 3, 2023

as explained in the docs, domain start and end is not guaranteed to be exactly the first and last day of the month

https://cal-heatmap.com/docs/options/subDomain#ghday

it's snapped to the last and first week of the month, to avoid duplicate columns on navigation

It's not a locale issue

@wa0x6e wa0x6e closed this as completed Mar 3, 2023
@wa0x6e
Copy link
Owner

wa0x6e commented Mar 3, 2023

Docs has been updated to highlight this point

Issue #325 may fix this issue in some case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants