Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional options for bars configuration #64

Closed
RaitaroH opened this issue Oct 2, 2018 · 9 comments
Closed

Additional options for bars configuration #64

RaitaroH opened this issue Oct 2, 2018 · 9 comments
Assignees

Comments

@RaitaroH
Copy link

RaitaroH commented Oct 2, 2018

First of all I would love to be able to put Glava on the right edge of my screen. Is it even possible through a custom bars config or not?

Also if that happens, I wold like the bars to go from the left edge to the right. So basically is like flipping the whole thing.

I tried #define ROTATE () in the bars.glsl but with not much success. If anything it only moves the window around the screen if I don't set Glava to my window screen.

@jarcode-foss
Copy link
Owner

@RaitaroH If I understand your requirements, you can't configure such in the bars.glsl file, but the shaders for the module can certainly be edited to allow that. I can add more options for the bars module if I find the time.

Just to clarify, you want:

  • Vertically rendered or 90 degree rotated bars module (not possible without editing shaders)
  • Inverted audio buffers (currently possible, use #define DIRECTION 1).

Is that correct?

@jarcode-foss jarcode-foss self-assigned this Oct 2, 2018
@jarcode-foss jarcode-foss changed the title Glava edge position Vertical bars configuration Oct 3, 2018
@RaitaroH
Copy link
Author

RaitaroH commented Oct 3, 2018

To get that I had to rotate in GIMP by -90.
clear

Also I don't think #define DIRECTION 1 is that. To me it looks like it flips the bars horizontally and adds a divider in the middle. Here is what I meant (I personally want it as the above picture, so not sure if this is even required, but maybe switching from right to left or something):
flip

@Seltyk
Copy link

Seltyk commented Oct 3, 2018

I support this; I'd love to put the left side audio on the left border of my screen and the right side audio on the right. Bonus points if lower frequencies are closer to the bottom border and if I can do this with graph mode, as well. That'd be dope

@jarcode-foss
Copy link
Owner

I see, you want it up-side down. That's pretty easy, give me a second.

@jarcode-foss jarcode-foss changed the title Vertical bars configuration Additional options for bars configuration Oct 4, 2018
@jarcode-foss
Copy link
Owner

jarcode-foss commented Oct 4, 2018

@RaitaroH You can now use #define FLIP 1 in bars.glsl to get the output in your second picture on master (re-run make install or update /etc/xdg/glava/bars/1.glsl).

I'll keep this open for now to add the other options, @wundrweapon's suggestion is also interesting.

@jarcode-foss
Copy link
Owner

@RaitaroH and that commit added #define MIRROR_YX 1, which effectively switches the X and Y axis in the shader, causing it to render on the left side of the window. You can use #define FLIP 1 in combination with this option to make it render on the right.

@RaitaroH
Copy link
Author

RaitaroH commented Oct 4, 2018

@wacossusca34 awesome. Thank you.

@RaitaroH RaitaroH closed this as completed Oct 4, 2018
@RaitaroH
Copy link
Author

RaitaroH commented Oct 4, 2018

screenshot_20181004_075159

Result.

@allusive-dev
Copy link

Hello, I saw this and had a similar feature request. Can you make bars able to have a custom rotation set like you can with radial. I am wanting the bars on a specific angle but after fiddling with the frag files I am not sure how to get it to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants