Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN en consistency #816

Closed
1 of 2 tasks
vincentvanhees opened this issue Jun 28, 2023 · 2 comments
Closed
1 of 2 tasks

EN en consistency #816

vincentvanhees opened this issue Jun 28, 2023 · 2 comments

Comments

@vincentvanhees
Copy link
Member

vincentvanhees commented Jun 28, 2023

Following on from comment by @jhmigueles here:

The column for Euclidian Norm in metalong object is not consistent in case across sensor brands: https://github.com/wadpac/GGIR/blob/master/R/g.getmeta.R#L351-L357. For some brands we use EN and for other en.

This would for example address the issue of not being able to process multiple brands at the same time for at least some combinations of brands: https://groups.google.com/g/RpackageGGIR/c/gSihX0GcrV8/m/AXTIBUsTAAAJ

Proposal:

  • Make sure elsewhere in GGIR this case difference is ignored, for example when data is appended or when code tries to identify this column.
  • Update en to EN in function g.getmeta().

The result should be that all new output will have EN while GGIR can still handle previously processed en data.

@l-k-
Copy link
Collaborator

l-k- commented Feb 14, 2024

PR #1027 updates g.getmeta() to always use uppercase EN, here's the relevant commit: 579f3ac

@vincentvanhees
Copy link
Member Author

Closing this issue, because seems to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants