Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unknown to Narrow #187

Merged
merged 1 commit into from
Aug 18, 2023
Merged

feat: add unknown to Narrow #187

merged 1 commit into from
Aug 18, 2023

Conversation

tmm
Copy link
Member

@tmm tmm commented Aug 18, 2023

Description

Adds unknown support to Narrow<...>

Additional Information

  • I read the contributing guide
  • I added documentation related to the changes made.
  • I added or updated tests related to the changes made.

Your ENS/address: awkweb.eth


PR-Codex overview

Focus of this PR:

Patch to add support for unknown type in the Narrow function.

Detailed summary:

  • Added unknown support to the Narrow function in src/narrow.ts
  • Updated the Narrow type definition to include unknown in the union type
  • Added tests for Narrow function in src/narrow.test-d.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: 7972933

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 3:40pm

@commit-lint
Copy link

commit-lint bot commented Aug 18, 2023

Features

Contributors

tmm

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 48.3 kB

ℹ️ View Unchanged
Filename Size
dist/cjs/abi.js 123 B
dist/cjs/config.js 126 B
dist/cjs/errors.js 577 B
dist/cjs/human-readable/errors/abiItem.js 537 B
dist/cjs/human-readable/errors/abiParameter.js 804 B
dist/cjs/human-readable/errors/signature.js 420 B
dist/cjs/human-readable/errors/splitParameters.js 404 B
dist/cjs/human-readable/errors/struct.js 338 B
dist/cjs/human-readable/formatAbi.js 294 B
dist/cjs/human-readable/formatAbiItem.js 420 B
dist/cjs/human-readable/formatAbiParameter.js 487 B
dist/cjs/human-readable/formatAbiParameters.js 313 B
dist/cjs/human-readable/parseAbi.js 348 B
dist/cjs/human-readable/parseAbiItem.js 439 B
dist/cjs/human-readable/parseAbiParameter.js 470 B
dist/cjs/human-readable/parseAbiParameters.js 527 B
dist/cjs/human-readable/runtime/cache.js 616 B
dist/cjs/human-readable/runtime/signatures.js 782 B
dist/cjs/human-readable/runtime/structs.js 1.03 kB
dist/cjs/human-readable/runtime/utils.js 2.13 kB
dist/cjs/human-readable/types/signatures-test-d.js 440 B
dist/cjs/human-readable/types/signatures.js 127 B
dist/cjs/human-readable/types/structs.js 127 B
dist/cjs/human-readable/types/utils.js 124 B
dist/cjs/index.js 743 B
dist/cjs/narrow.js 169 B
dist/cjs/regex.js 362 B
dist/cjs/test.js 597 B
dist/cjs/test/abis.js 5.93 kB
dist/cjs/test/human-readable.js 3.6 kB
dist/cjs/types.js 124 B
dist/cjs/utils.js 124 B
dist/cjs/version.js 149 B
dist/cjs/zod.js 2.06 kB
dist/esm/abi.js 62 B
dist/esm/config.js 65 B
dist/esm/errors.js 524 B
dist/esm/human-readable/errors/abiItem.js 454 B
dist/esm/human-readable/errors/abiParameter.js 674 B
dist/esm/human-readable/errors/signature.js 339 B
dist/esm/human-readable/errors/splitParameters.js 345 B
dist/esm/human-readable/errors/struct.js 282 B
dist/esm/human-readable/formatAbi.js 214 B
dist/esm/human-readable/formatAbiItem.js 339 B
dist/esm/human-readable/formatAbiParameter.js 405 B
dist/esm/human-readable/formatAbiParameters.js 230 B
dist/esm/human-readable/parseAbi.js 267 B
dist/esm/human-readable/parseAbiItem.js 353 B
dist/esm/human-readable/parseAbiParameter.js 383 B
dist/esm/human-readable/parseAbiParameters.js 436 B
dist/esm/human-readable/runtime/cache.js 554 B
dist/esm/human-readable/runtime/signatures.js 572 B
dist/esm/human-readable/runtime/structs.js 948 B
dist/esm/human-readable/runtime/utils.js 2.04 kB
dist/esm/human-readable/types/signatures-test-d.js 367 B
dist/esm/human-readable/types/signatures.js 69 B
dist/esm/human-readable/types/structs.js 66 B
dist/esm/human-readable/types/utils.js 64 B
dist/esm/index.js 345 B
dist/esm/narrow.js 97 B
dist/esm/regex.js 284 B
dist/esm/test.js 298 B
dist/esm/test/abis.js 5.8 kB
dist/esm/test/human-readable.js 3.49 kB
dist/esm/types.js 64 B
dist/esm/utils.js 64 B
dist/esm/version.js 82 B
dist/esm/zod.js 1.89 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #187 (7972933) into main (54a8985) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   99.90%   99.90%   -0.01%     
==========================================
  Files          21       21              
  Lines        2049     2048       -1     
  Branches      325      325              
==========================================
- Hits         2047     2046       -1     
  Misses          2        2              
Files Changed Coverage Δ
src/narrow.ts 100.00% <100.00%> (ø)

@tmm tmm merged commit 4a0131f into main Aug 18, 2023
17 checks passed
@tmm tmm deleted the tmm/narrow-unknown branch August 18, 2023 15:44
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant