Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse Abi with zod as readonly array #200

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

mathieu-bour
Copy link
Contributor

@mathieu-bour mathieu-bour commented Oct 11, 2023

Description

Supersedes #197

This PR sets the zod Abi schema from abitype/zod as readonly [] to match the Abi type declared in abitype.

Additional Information

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

PR-Codex overview

Focus of the PR:

The focus of this PR is to mark the Abi Zod schema as readonly.

Detailed summary:

  • Marked Abi Zod schema as readonly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: eb55b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abitype Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 7:32am

@commit-lint
Copy link

commit-lint bot commented Oct 11, 2023

Bug Fixes

  • parse Abi with zod as readonly array (82db7b4)

Chore

  • update .changeset/hungry-pets-switch.md (eb55b39)

Contributors

mathieu-bour

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f8abb47) 99.83% compared to head (eb55b39) 99.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          26       26           
  Lines        6076     6082    +6     
  Branches      195      195           
=======================================
+ Hits         6066     6072    +6     
  Misses          8        8           
  Partials        2        2           
Files Coverage Δ
packages/abitype/src/zod.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.changeset/hungry-pets-switch.md Outdated Show resolved Hide resolved
Co-authored-by: awkweb <tom@meagher.co>
@tmm tmm merged commit 56f8201 into wevm:main Oct 12, 2023
15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
@mathieu-bour mathieu-bour deleted the zod-readonly-abi branch October 14, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants