Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

fix: use dynamic import for execa for cjs #19

Merged
merged 4 commits into from
Apr 29, 2023
Merged

fix: use dynamic import for execa for cjs #19

merged 4 commits into from
Apr 29, 2023

Conversation

fubhy
Copy link
Collaborator

@fubhy fubhy commented Apr 28, 2023

Fixes #17

I'm inclined to just use top level await here.


PR-Codex overview

This PR updates the @viem/anvil package and its dependencies, including typescript and tsx, and fixes some imports. It also updates the tsconfig files and adds some tests.

Detailed summary

  • Update @viem/anvil package to fix imports
  • Update typescript to version 5.0.4
  • Update tsx to version 3.12.6
  • Update get-port to version 6.1.2
  • Update @types/node to version 18.16.0
  • Update tsconfig.json files
  • Add tests for getVersion and createAnvil functions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: 63dd039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viem/anvil Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@commit-lint
Copy link

commit-lint bot commented Apr 28, 2023

Bug Fixes

  • use dynamic import for execa for cjs (ae86e9f)
  • fix dynamic imports (4c739c1)

Chore

Contributors

fubhy

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2023

Size Change: +42 B (0%)

Total Size: 13.6 kB

Filename Size Change
packages/anvil.js/dist/cjs/anvil/createAnvil.js 1.61 kB +6 B (0%)
packages/anvil.js/dist/cjs/anvil/getVersion.js 324 B +8 B (+3%)
packages/anvil.js/dist/esm/anvil/createAnvil.js 1.52 kB +10 B (+1%)
packages/anvil.js/dist/esm/anvil/getVersion.js 257 B +18 B (+8%) 🔍
ℹ️ View Unchanged
Filename Size
packages/anvil.js/dist/cjs/anvil/stripColors.js 327 B
packages/anvil.js/dist/cjs/anvil/toArgs.js 405 B
packages/anvil.js/dist/cjs/anvil/toFlagCase.js 282 B
packages/anvil.js/dist/cjs/index.js 355 B
packages/anvil.js/dist/cjs/pool/createPool.js 906 B
packages/anvil.js/dist/cjs/proxy/createProxy.js 1.31 kB
packages/anvil.js/dist/cjs/proxy/fetchLogs.js 408 B
packages/anvil.js/dist/cjs/proxy/parseRequest.js 495 B
packages/anvil.js/dist/cjs/proxy/startProxy.js 717 B
packages/anvil.js/dist/cjs/types.js 124 B
packages/anvil.js/dist/esm/anvil/stripColors.js 260 B
packages/anvil.js/dist/esm/anvil/toArgs.js 334 B
packages/anvil.js/dist/esm/anvil/toFlagCase.js 216 B
packages/anvil.js/dist/esm/index.js 165 B
packages/anvil.js/dist/esm/pool/createPool.js 815 B
packages/anvil.js/dist/esm/proxy/createProxy.js 1.25 kB
packages/anvil.js/dist/esm/proxy/fetchLogs.js 338 B
packages/anvil.js/dist/esm/proxy/parseRequest.js 436 B
packages/anvil.js/dist/esm/proxy/startProxy.js 638 B
packages/anvil.js/dist/esm/types.js 64 B

compressed-size-action

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore esbuild@0.17.17
📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
esbuild@0.17.17 (added) postinstall pnpm-lock.yaml, examples/example-node/package.json via tsx@3.12.6, examples/example-vitest/package.json via , packages/anvil.js/package.json via @vitest/coverage-c8@0.30.1, vite-tsconfig-paths@4.2.0
Pull request alert summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
tsx@3.12.6 eval, filesystem, shell, environment +7 hirokiosame

@fubhy fubhy merged commit 5848df9 into main Apr 29, 2023
@fubhy fubhy deleted the fix/execa-cjs branch April 29, 2023 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cjs build doesn't work in cjs
1 participant