Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getProof #1316

Merged
merged 4 commits into from
Oct 8, 2023
Merged

feat: getProof #1316

merged 4 commits into from
Oct 8, 2023

Conversation

jxom
Copy link
Member

@jxom jxom commented Oct 8, 2023

Support eth_getProof: https://eips.ethereum.org/EIPS/eip-1186


PR-Codex overview

Detailed summary:

  • Added getProof function to retrieve the account and storage values of a specified account, including the Merkle-proof.
  • Created Proof type to represent the proof data.
  • Updated various files to include references to getProof and Proof.

This PR focuses on adding the getProof function and related changes to provide the ability to retrieve the account and storage values of a specified account, including the Merkle-proof.

The following files were skipped due to too many changes: site/docs/actions/public/getProof.md, src/actions/public/getProof.test.ts, src/utils/formatters/proof.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2023

🦋 Changeset detected

Latest commit: 071186e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Oct 8, 2023 11:01pm

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (21bffe4) 99.82% compared to head (071186e) 99.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   99.82%   99.81%   -0.02%     
==========================================
  Files         387      389       +2     
  Lines       34502    34673     +171     
  Branches     1958     1962       +4     
==========================================
+ Hits        34441    34608     +167     
- Misses         54       58       +4     
  Partials        7        7              
Files Coverage Δ
src/actions/public/getProof.ts 100.00% <100.00%> (ø)
src/clients/decorators/public.ts 100.00% <100.00%> (ø)
src/types/eip1193.ts 100.00% <100.00%> (ø)
src/types/rpc.ts 100.00% <100.00%> (ø)
src/utils/formatters/proof.ts 95.83% <95.83%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.11 KB (+0.19% 🔺) 1.2 s (+0.19% 🔺) 2.7 s (+56.88% 🔺) 3.9 s
viem (cjs) 76.88 KB (+0.2% 🔺) 1.6 s (+0.2% 🔺) 3.3 s (+7.37% 🔺) 4.9 s
viem (minimal surface - tree-shaking) 3.85 KB (0%) 77 ms (0%) 665 ms (+23.85% 🔺) 742 ms
viem/accounts 89.01 KB (0%) 1.8 s (0%) 1.7 s (+42.9% 🔺) 3.5 s
viem/accounts (tree-shaking) 19.37 KB (0%) 388 ms (0%) 717 ms (-13.91% 🔽) 1.2 s
viem/actions 43.25 KB (0%) 865 ms (0%) 13.2 s (+31.34% 🔺) 14.1 s
viem/actions (tree-shaking) 350 B (0%) 10 ms (0%) 320 ms (-47.49% 🔽) 330 ms
viem/chains 16.98 KB (0%) 340 ms (0%) 1.4 s (+41.31% 🔺) 1.7 s
viem/chains (tree-shaking) 470 B (0%) 10 ms (0%) 572 ms (+83.29% 🔺) 582 ms
viem/chains/utils 7.97 KB (0%) 160 ms (0%) 547 ms (-6.63% 🔽) 706 ms
viem/chains/utils (tree-shaking) 5.24 KB (0%) 105 ms (0%) 566 ms (-25.49% 🔽) 670 ms
viem/ens 43.25 KB (0%) 865 ms (0%) 8.1 s (-20.29% 🔽) 8.9 s
viem/ens (tree-shaking) 17.94 KB (0%) 359 ms (0%) 837 ms (+0.5% 🔺) 1.2 s

@jxom jxom merged commit ae5c03a into main Oct 8, 2023
20 of 23 checks passed
@jxom jxom deleted the jxom/getProof branch October 8, 2023 23:09
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant