fix: conditional types for poll options #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c54fca The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TldrThis PR fixes conditional types for poll options on Detailed summary
|
|
Size Change: 0 B Total Size: 263 kB ℹ️ View Unchanged
|
1 task
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 99.86% 99.87%
=======================================
Files 263 263
Lines 17268 17268
Branches 1820 1819 -1
=======================================
+ Hits 17245 17246 +1
+ Misses 21 20 -1
Partials 2 2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342
Fixes #341
This fixes the aforementioned issues. However (and without having looked into it & thought about it further yet), I think it would be better to remove knowledge of these transport specific options from the client completely. To me that looks like reversed coupling.