Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error messaging & coalesce error messages from nodes #81

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

jxom
Copy link
Member

@jxom jxom commented Feb 21, 2023

Making error messages more dope.

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: d207202

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 2:27AM (UTC)
viem-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 2:27AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Size Change: +2.51 kB (+6%) 🔍

Total Size: 42.7 kB

Filename Size Change
dist/chains.js 1.3 kB -2 B (0%)
dist/chunk-67DKKHAV.js 0 B -1.72 kB (removed) 🏆
dist/chunk-7GQB4KE5.js 0 B -5.75 kB (removed) 🏆
dist/chunk-FPEKYEVU.js 0 B -1.39 kB (removed) 🏆
dist/chunk-JJ4FDDDW.js 0 B -1.63 kB (removed) 🏆
dist/chunk-NYWN5V47.js 0 B -21 kB (removed) 🏆
dist/contract.js 474 B -2 B (0%)
dist/ens.js 353 B -1 B (0%)
dist/index.js 4.49 kB +158 B (+4%)
dist/public.js 468 B -3 B (-1%)
dist/test.js 520 B -1 B (0%)
dist/utils/index.js 927 B +58 B (+7%) 🔍
dist/wallet.js 293 B -3 B (-1%)
dist/chunk-2UFOKPIM.js 5.77 kB +5.77 kB (new file) 🆕
dist/chunk-FG4BPIQS.js 1.64 kB +1.64 kB (new file) 🆕
dist/chunk-HZOWXGNI.js 1.38 kB +1.38 kB (new file) 🆕
dist/chunk-JRIRU5AU.js 23.3 kB +23.3 kB (new file) 🆕
dist/chunk-P3DZPNGJ.js 1.72 kB +1.72 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/window.js 67 B

compressed-size-action

@jxom jxom requested a review from tmm February 21, 2023 03:44
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at sales@codecov.io

.changeset/breezy-jobs-poke.md Outdated Show resolved Hide resolved
args: SendTransactionArgs<any> = {},
) {
const message = err.details.toLowerCase()
if (message.match(FeeCapTooHighError.nodeMessage))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.test usually much faster than .match if we are just doing boolean check.

https://jsbench.me/0qleeez9wp/1

Suggested change
if (message.match(FeeCapTooHighError.nodeMessage))
if (FeeCapTooHighError.nodeMessage.test(message))

Should update all the place below too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants