-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better error messaging & coalesce error messages from nodes #81
Conversation
🦋 Changeset detectedLatest commit: d207202 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +2.51 kB (+6%) 🔍 Total Size: 42.7 kB
ℹ️ View Unchanged
|
Codecov upload limit reached
|
src/utils/errors/getNodeError.ts
Outdated
args: SendTransactionArgs<any> = {}, | ||
) { | ||
const message = err.details.toLowerCase() | ||
if (message.match(FeeCapTooHighError.nodeMessage)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.test
usually much faster than .match
if we are just doing boolean check.
https://jsbench.me/0qleeez9wp/1
if (message.match(FeeCapTooHighError.nodeMessage)) | |
if (FeeCapTooHighError.nodeMessage.test(message)) |
Should update all the place below too :)
Making error messages more dope.