Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in docs for watchBlockNumber #2981

Closed
1 task done
sunmer opened this issue Sep 7, 2023 · 9 comments
Closed
1 task done

Error in docs for watchBlockNumber #2981

sunmer opened this issue Sep 7, 2023 · 9 comments
Labels
Good First Issue Misc: Good First Issue

Comments

@sunmer
Copy link

sunmer commented Sep 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package Version

1.3.9

Current Behavior

Property listen is not an optional argument - contrary to what the docs say
https://github.com/wagmi-dev/wagmi/blob/5e4bc8e26aa9bfc28f654c2d01a38c8d1d7ecc4e/docs/pages/core/actions/watchBlockNumber.en-US.mdx#L52

Expected Behavior

No response

Steps To Reproduce

No response

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)

No response

Anything else?

No response

@tmm tmm added the Good First Issue Misc: Good First Issue label Sep 7, 2023
@tmm
Copy link
Member

tmm commented Sep 7, 2023

Easy fix if you want credit! PR welcome.

@SrijanShovit
Copy link
Contributor

Hey @sunmer and @tmm Can I work on this issue?

@tmm
Copy link
Member

tmm commented Sep 8, 2023

Go got it!

@SrijanShovit
Copy link
Contributor

Hi @tmm when I try to run a react app after installing wagmi, it gives No wagmi config found. Ensure you have set up a config: https://wagmi.sh/react/config.
Could you please help me?

@glitch-txs
Copy link
Collaborator

@SrijanShovit you need to wrap you app with this https://wagmi.sh/react/WagmiConfig

@SrijanShovit
Copy link
Contributor

Thanks @glitch-txs

@SrijanShovit
Copy link
Contributor

Hey @tmm , I have made a pull request for this issue as PR #2990 . Kindly review. Thanks!!

@tmm tmm closed this as completed Sep 10, 2023
@SrijanShovit
Copy link
Contributor

thanks @tmm 😊

Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest wagmi version. If you have any other comments you can create a new discussion.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Misc: Good First Issue
Projects
None yet
Development

No branches or pull requests

4 participants