Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whole tree expands when layer selection is changed #4

Closed
willmurphyscode opened this issue Jun 2, 2018 · 2 comments
Closed

Whole tree expands when layer selection is changed #4

willmurphyscode opened this issue Jun 2, 2018 · 2 comments

Comments

@willmurphyscode
Copy link
Collaborator

To repro

  1. View a tree, go to the main view.
  2. CTRL + space over to the left side view
  3. Move press down arrow

Expected behavior:

Collapsed nodes that exist in both views should stay collapsed

Actual behavior:

Entire tree re-expands.
@wagoodman
Copy link
Owner

wagoodman commented Jun 3, 2018 •
edited

Yeah, this is because we rebuild the entire tree from the bottom layer, ignoring any metadata on the existing tree (such as collapsed) when we add the upper layers back on.

@wagoodman
Copy link
Owner

(only fixed the collapsed state, no other metadata yet needs this preservation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagoodman @willmurphyscode