forked from openshift/origin
/
instance.go
116 lines (94 loc) · 4.5 KB
/
instance.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
/*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package validation
import (
apivalidation "k8s.io/apimachinery/pkg/api/validation"
"k8s.io/apimachinery/pkg/util/validation/field"
sc "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog"
)
// validateInstanceName is the validation function for Instance names.
var validateInstanceName = apivalidation.NameIsDNSSubdomain
// ValidateInstance validates an Instance and returns a list of errors.
func ValidateInstance(instance *sc.Instance) field.ErrorList {
return internalValidateInstance(instance, true)
}
func internalValidateInstance(instance *sc.Instance, create bool) field.ErrorList {
allErrs := field.ErrorList{}
allErrs = append(allErrs, apivalidation.ValidateObjectMeta(&instance.ObjectMeta, true, /*namespace*/
validateInstanceName,
field.NewPath("metadata"))...)
allErrs = append(allErrs, validateInstanceSpec(&instance.Spec, field.NewPath("Spec"), create)...)
allErrs = append(allErrs, validateInstanceStatus(&instance.Status, field.NewPath("Status"), create)...)
return allErrs
}
func validateInstanceSpec(spec *sc.InstanceSpec, fldPath *field.Path, create bool) field.ErrorList {
allErrs := field.ErrorList{}
if "" == spec.ServiceClassName {
allErrs = append(allErrs, field.Required(fldPath.Child("serviceClassName"), "serviceClassName is required"))
}
for _, msg := range validateServiceClassName(spec.ServiceClassName, false /* prefix */) {
allErrs = append(allErrs, field.Invalid(fldPath.Child("serviceClassName"), spec.ServiceClassName, msg))
}
if "" == spec.PlanName {
allErrs = append(allErrs, field.Required(fldPath.Child("planName"), "planName is required"))
}
for _, msg := range validateServicePlanName(spec.PlanName) {
allErrs = append(allErrs, field.Invalid(fldPath.Child("planName"), spec.PlanName, msg))
}
return allErrs
}
func validateInstanceStatus(spec *sc.InstanceStatus, fldPath *field.Path, create bool) field.ErrorList {
errors := field.ErrorList{}
// TODO(vaikas): Implement more comprehensive status validation.
// https://github.com/kubernetes-incubator/service-catalog/issues/882
// Do not allow the instance to be ready if an async operation is ongoing
// ongoing
if spec.AsyncOpInProgress {
for _, c := range spec.Conditions {
if c.Type == sc.InstanceConditionReady && c.Status == sc.ConditionTrue {
errors = append(errors, field.Forbidden(fldPath.Child("Conditions"), "Can not set InstanceConditionReady to true when an async operation is in progress"))
}
}
}
return errors
}
// internalValidateInstanceUpdateAllowed ensures there is not an asynchronous
// operation ongoing with the instance before allowing an update to go through.
func internalValidateInstanceUpdateAllowed(new *sc.Instance, old *sc.Instance) field.ErrorList {
errors := field.ErrorList{}
if old.Status.AsyncOpInProgress {
errors = append(errors, field.Forbidden(field.NewPath("Spec"), "Another operation for this service instance is in progress"))
}
return errors
}
// ValidateInstanceUpdate validates a change to the Instance's spec.
func ValidateInstanceUpdate(new *sc.Instance, old *sc.Instance) field.ErrorList {
allErrs := field.ErrorList{}
allErrs = append(allErrs, internalValidateInstanceUpdateAllowed(new, old)...)
allErrs = append(allErrs, internalValidateInstance(new, false)...)
return allErrs
}
func internalValidateInstanceStatusUpdateAllowed(new *sc.Instance, old *sc.Instance) field.ErrorList {
errors := field.ErrorList{}
// TODO(vaikas): Are there any cases where we do not allow updates to
// Status during Async updates in progress?
return errors
}
// ValidateInstanceStatusUpdate checks that when changing from an older
// instance to a newer instance is okay. This only checks the instance.Status field.
func ValidateInstanceStatusUpdate(new *sc.Instance, old *sc.Instance) field.ErrorList {
allErrs := field.ErrorList{}
allErrs = append(allErrs, internalValidateInstanceStatusUpdateAllowed(new, old)...)
allErrs = append(allErrs, internalValidateInstance(new, false)...)
return allErrs
}