Sync modeladmin field ordering logic with django's #6931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://thatguystonemodeladmin-orderin-9isbe.squash.io |
thatguystone
force-pushed
the
modeladmin-ordering
branch
from
3ebd58c
to
7e17893
Compare
|
Hi @thatguystone. This is looking great, thank you! Would you be okay to add a couple of tests to cover the new cases? I would be surprised if there wasn't something in Django that you could use for inspiration. |
|
Hello, I'm closing this as it's quite dated and we no longer accepting PRs for new ModelAdmin features in Wagtail as per wagtail/rfcs#85. If you'd like, you could create a new PR to the wagtail-modeladmin repository. If the bug fix is critical, we might consider backporting it to the Wagtail repo during the deprecation period. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the original code was copied from
django.contrib.admin.views, and it's gotten a bit out-of-sync; this brings it back in-sync with django/contrib/admin/views/main.py@2411b8b.Fixes wagtail-nest/wagtail-modeladmin#29