Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end pre-launch tasks checklist #125

Closed
7 tasks done
Tracked by #136
thibaudcolas opened this issue Oct 18, 2022 · 6 comments · Fixed by #163
Closed
7 tasks done
Tracked by #136

Front-end pre-launch tasks checklist #125

thibaudcolas opened this issue Oct 18, 2022 · 6 comments · Fixed by #163
Assignees
Milestone

Comments

@thibaudcolas
Copy link
Member

thibaudcolas commented Oct 18, 2022

  • Request a site-wide accessibility audit from another front-end developer Accessibility check by Wagtail a11y team #76
  • Check fonts are set up to work on live domain and set up if not
  • Check favicon (check that a request direct to /favicon.ico serves up the icon regardless of where the image is actually stored.)
  • Check title tags and meta descriptions
  • [ ] Check all of the templates use the correct lang for the site’s intended audience (en-US, en-GB, or something else entirely)
  • Check social media sharing, twitter cards, facebook open graph
  • Check that the CSS and JS deployed to production has been minified by the front-end toolchain.
  • Check the site’s pages in Lighthouse, and report any issues
@nicklee
Copy link
Member

nicklee commented Oct 20, 2022

html lang is currently being output as en-latest

@nicklee
Copy link
Member

nicklee commented Oct 20, 2022

We have a favicon at /static/images/apple-touch-icon.png, /static/images/favicon-32x32.png and /static/images/favicon-16x16.png, there's also a favicon.ico in route, but the /favicon.ico url doesn't work so this needs update

@nicklee
Copy link
Member

nicklee commented Oct 20, 2022

WIP here: #163

@nicklee
Copy link
Member

nicklee commented Oct 20, 2022

Lighthouse report is all green, shame about the 99/100 ;) suspect it might be further improved when actually on the server with text compression

Image

@nicklee
Copy link
Member

nicklee commented Oct 24, 2022

All done other than the language field, I'm not sure how we should go about this, we might need to assign an additional value added to the self.locale.language_code setup that outputs an actual language code and not just the label that appears in the dropdown?

@thibaudcolas
Copy link
Member Author

Thank you @nicklee, created that one separately: #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants