Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP compatibility improvements #61

Closed
thibaudcolas opened this issue Aug 7, 2023 · 2 comments
Closed

CSP compatibility improvements #61

thibaudcolas opened this issue Aug 7, 2023 · 2 comments

Comments

@thibaudcolas
Copy link
Member

Follow-up to Extend Stimulus adoption #57. Further adoption of Stimulus to support stricter CSP policies (stop using inline JS to initialise features).

Exact improvements TBC in line with Stimulus adoption planning.

@lb-
Copy link
Member

lb- commented Aug 9, 2023

Update as at the 5.1 release (August 2023). See previous update comment: #57 (comment)

Currently implemented

We have 18 controllers implemented, 6 of which were added in the last release.

  • DialogController 'w-dialog'
  • DropdownController 'w-dropdown'
  • SwapController 'w-swap'
  • TagController 'w-tag'
  • TeleportController 'w-teleport'
  • TooltipController 'w-tooltip'

State of inline script usage

A list of areas of code that still use inline scripts, roughly from most common to least common, roughly being used to determine next steps.

  1. Date pickers (Migrate datetime chooser init script to Stimulus w-date wagtail#10261)
  2. Bulk actions (progress being made, no issue raised)
  3. Metadata/locale/config items - in limbo, need some direction on Ability to have a consistent approach to client-side (JS) metadata (aka global config) wagtail#9771
  4. Choosers/Workflow actions - no progress
  5. InlinePanel/formset - some pre-work issues created, no progress
  6. File upload / title changes
  7. Dirty form check / unsaved changes - issue created
  8. Initialise comments - no progress

Pull requests

Ready to review

Blocked

Inactive

@thibaudcolas
Copy link
Member Author

For a record of what shipped in v5.2, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: v5.2 November 2023
Development

No branches or pull requests

2 participants