Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DocSearch meta tags #251

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Remove DocSearch meta tags #251

merged 1 commit into from
Mar 8, 2023

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Mar 8, 2023

Cleaning up so our Algolia DocSearch integration for Wagtail itself is easier to manage in the future: we can have the meta tags defined on wagtail/wagtail, like all other aspects of the integration. And:

  • docsearch:name is useless (it’ll be the same for all builds of the docs)
  • docsearch:package_type is empty
  • docsearch:release is less apporpriate than docsearch:version.

Even docsearch:version isn’t well set up currently. Using the version variable means both the stable and vX.Y variants of the documentation would be indexed with the same version. We need to switch to the Read the Docs current_version instead (see wagtail/wagtail#10207).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants