Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import button on available snippet views #6

Merged
merged 4 commits into from May 28, 2020

Conversation

KalobTaulien
Copy link
Collaborator

Provides an import button for the snippet list view.

Included is a template tag (with tests) to determine if a model is setup in the settings. No additional validation added at this point, however.

image

Copy link

@tomdyson tomdyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KalobTaulien! A few wording tweaks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
wagtail_airtable/templatetags/wagtail_airtable_tags.py Outdated Show resolved Hide resolved
@KalobTaulien
Copy link
Collaborator Author

Thanks for the review @tomdyson! I've made all the suggested updates. Good eye.

Happy for this to be merged in?

Copy link
Collaborator

@jacobtoppm jacobtoppm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@KalobTaulien KalobTaulien merged commit 6ef7321 into master May 28, 2020
@KalobTaulien KalobTaulien deleted the import-button-support branch May 28, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants