Wagtail 4.2 support #79
Conversation
katdom13
force-pushed
the
support/wagtail-4.2-upgrade
branch
from
5603b67
to
ffc7f8c
Compare
katdom13
force-pushed
the
support/wagtail-4.2-upgrade
branch
from
ffc7f8c
to
dd795c3
Compare
|
Hi @katdom13, thanks for the contribution! ❤️ I'll check this out in detail when I have time. Please be patient. |
There was a problem hiding this comment.
@katdom13 Thanks the code changes look good to me. Just a couple of suggestions.
There was a problem hiding this comment.
Hi @katdom13 - sorry that it took me so long to properly review your pull request.
I'm really happy with your changes, but I do have one minor suggestion (see comment). Are you happy to make that change?
Thanks again for your help maintaining wagtail-bakery ❤️
examples/aws/example/models.py
Outdated
| from wagtail.core.models import Page | ||
| from wagtail import blocks | ||
| from wagtail.admin.panels import FieldPanel | ||
| from wagtail.admin.panels import FieldPanel as StreamFieldPanel |
There was a problem hiding this comment.
Suggestion: we can drop the StreamFieldPanel import and use FieldPanel in the example. I feel like this aliased import may confuse users reading this example.
examples/multisite/example/models.py
Outdated
| from wagtail.core.models import Page | ||
| from wagtail import blocks | ||
| from wagtail.admin.panels import FieldPanel | ||
| from wagtail.admin.panels import FieldPanel as StreamFieldPanel |
| from wagtail.core.fields import StreamField | ||
| from wagtail.core.models import Page | ||
| from wagtail import blocks | ||
| from wagtail.admin.panels import FieldPanel, StreamFieldPanel |
| if WAGTAIL_VERSION >= (2, 9): | ||
| wagtail_middleware = [ | ||
| 'wagtail.contrib.redirects.middleware.RedirectMiddleware', | ||
| ] | ||
| else: | ||
| wagtail_middleware = [ | ||
| 'wagtail.core.middleware.SiteMiddleware', | ||
| 'wagtail.contrib.redirects.middleware.RedirectMiddleware', | ||
| ] |
There was a problem hiding this comment.
Wow, that is old compatibility code. Thanks for cleaning that up! 🚀
loicteixeira
requested review from
Stormheg and
nickmoreton
and removed request for
nickmoreton
* main: Wagtail 4.2 support (wagtail-nest#79) Update URLs to wagtail-nest (wagtail-nest#82)
Supress warnings from earlier wagtail versions