Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Update the edit history of a page after transfer #56

Open
stevejalim opened this issue Oct 5, 2020 · 2 comments
Open

Suggestion: Update the edit history of a page after transfer #56

stevejalim opened this issue Oct 5, 2020 · 2 comments

Comments

@stevejalim
Copy link

At the moment, when an import is done, the history table of an imported Page is not updated.

It would be useful to at least show that a Page (or similar) was last updated via import.

While we can't guarantee that a User corresponding to the original last editor will exist in the destination site, we can still add useful info without needing to get into explicit attribution.

Simply, PageLogEntry can handle a null user for system actions, so we could create a non-user-linked PageLogEntry post-import for each imported Page with a message saying that the page was last updated on this server via Wagtail-Transfer, and potentially with the verbose name and ID of the admin who triggered the import, which we will have available.

This would also be handy in creating an audit trail for showing which admins had triggered an import, and when.

(Am happy to write this up into a more coherent spec/structure, btw.)

@jacobtoppm
Copy link
Member

This sounds like a good plan IMO - now audit logging is in, we should definitely be hooking into it. We could potentially use the uuid of the user to try to fetch the user on the destination site if they exist, and fall back to null user if not.

@easherma-truth
Copy link

easherma-truth commented Jan 5, 2023

This has been confusing, would be good to at least document the expected behavior with page changes via import. Sometimes I see an entry in the editor history, sometimes I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants