Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django main – models.E025: The property 'revisions'/'workflow_states' clashes with a related field accessor #11746

Closed
laymonage opened this issue Mar 11, 2024 · 2 comments · May be fixed by #11750
Closed

Django main – models.E025: The property 'revisions'/'workflow_states' clashes with a related field accessor #11746

laymonage opened this issue Mar 11, 2024 · 2 comments · May be fixed by #11750
Assignees
@laymonage
Labels
Compatibility For issues that explicitly relate to compatibility with dependencies and other packages component:Django type:Bug
Milestone
6.1

Comments

@laymonage
Copy link
Member

Issue Summary

Tests are failing against Django's main branch with the following system check errors:

SystemCheckError: System check identified some issues:

ERRORS:
tests.FullFeaturedSnippet: (models.E025) The property 'revisions' clashes with a related field accessor.
tests.FullFeaturedSnippet: (models.E025) The property 'workflow_states' clashes with a related field accessor.

Steps to Reproduce

  1. Install Django from its main branch
  2. Run Wagtail's tests

Technical details

The error shows up as of django/django#17936.

Per discussion in #11591 (review) we ought to implement the default revisions and workflow_states in the mixins as GenericRelations anyway, so perhaps we can tackle the two things at once.
@laymonage laymonage added type:Bug component:Django Compatibility For issues that explicitly relate to compatibility with dependencies and other packages labels Mar 11, 2024
@laymonage laymonage added this to the 6.1 milestone Mar 11, 2024
@laymonage laymonage self-assigned this Mar 11, 2024
@laymonage laymonage mentioned this issue Mar 11, 2024
Draft
@laymonage
Copy link
Member Author

This might be a bug in Django itself, I've raised https://code.djangoproject.com/ticket/35301 in upstream.

@laymonage laymonage mentioned this issue Mar 15, 2024
Merged
@laymonage
Copy link
Member Author

This has been fixed in upstream, but I'd still like to get #11750 in for 6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laymonage laymonage

Labels
Compatibility For issues that explicitly relate to compatibility with dependencies and other packages component:Django type:Bug
Projects
Wagtail 6.1 release planning
Status: ✅ Done
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

Add default GenericRelations for RevisionMixin and WorkflowMixin laymonage/wagtail
1 participant
@laymonage