Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 p, h2, h3, undo, redo buttons not working in hallo RichText editor #3400

Closed
ababic opened this issue Feb 24, 2017 · 5 comments
Closed

Comments

@ababic
Copy link
Contributor

ababic commented Feb 24, 2017

Issue Summary

A few of the buttons on the hallo editor toolbar are failing to work in IE11. They don't throw errors, but they just don't seem to do anything.

The buttons we are seeing issues with are as follows, but there could be more that are effected:

  • p
  • h2
  • h3
  • undo
  • redo

Steps to Reproduce

  1. Running an up-to-date version of the wagtaildemo project with latest versions of wagtail/other dependencies installed
  2. Create a new page that has a default RichText widget on the edit form somewhere (either as a RichTextField or a StreamField)
  3. Try out the above buttons in IE11
@ralphjacobs
Copy link
Contributor

ralphjacobs commented Mar 23, 2017

> Quite a search but i think i found it.
> It has to do with the document.execCommand of contentEditable in IE.
> 
> IE needs a real 'tag':
>         document.execCommand('formatBlock', false, 'h1'); (doesn't work) vs
>         document.execCommand('formatBlock', false, '<h1>'); (works)
> 


@ralphjacobs
Copy link
Contributor

http://jsfiddle.net/Xotic750/ZxePd/ (undo / redo) seems to work in IE11

@ralphjacobs
Copy link
Contributor

Since there is a Deprecate Hallo.js issue: #2409
I'm really wondering if we should put time/effort on fixing this in Hallojs

@gasman
Copy link
Collaborator

gasman commented Mar 23, 2017

Replacing hallo.js is probably (very roughly) about 6 months away, so if there's a simple fix for IE11 we can make in the meantime then we should go ahead and apply that. If not, then this ticket should be left open, and closed when hallo.js is finally killed off...

@thibaudcolas
Copy link
Member

thibaudcolas commented Jan 26, 2018

The new editor doesn't have this issue (it has other IE11 issues of its own though!). Hallo still affected, but closing anyway.

@thibaudcolas thibaudcolas added the status:Won't Fix The issue is outside the Wagtail scope label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants