Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebP Support #5092

Closed
edmenendez opened this issue Feb 20, 2019 · 3 comments
Closed

WebP Support #5092

edmenendez opened this issue Feb 20, 2019 · 3 comments

Comments

@edmenendez
Copy link

I'm opening this issue so that we can keep track of requirements and how support for WebP should be implemented. I'm hoping core contributors would chip in with advise on what areas of the system to look at and minimum features required for this.

Something that is needed is for this PR to be released in Willow: wagtail/Willow#70

Wagtail then needs to be tested against that new version of Willow to make sure it works. Additionally, there are places in the code that make some assumptions about image type that need to be fixed. i.e. https://github.com/wagtail/wagtail/blob/master/wagtail/images/models.py#L401 (thanks @gasman for pointing that out).

I would like to contribute to this feature if there's support within the community for it.

@frmdstryr
Copy link
Contributor

👍 Changes I made to support this: frmdstryr/wagtail@master...frmdstryr:db4271e350a8e54df05bf0b9b0fb436ec060211f (didn't update tests). It allows uploading webp but converts them to png as some browsers don't display webp images.

Also django's ImageField currently has an error due to this issue django/django#10331. The fix is only coming in 2.2 even though it was applied last year.

@onno-timmerman
Copy link
Contributor

I see that this was not added in latest wagtail release? Any reason why wepb is not yet supported?

@gasman
Copy link
Collaborator

gasman commented Oct 16, 2019

Completed in #5249 / #5629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants