You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When #9649 is merged, commenting on InlinePanels will be disabled. This is a feature that was never intended to be enabled without further development, so had a number of issues: child models that aren't yet saved to the database do not have a stable way to identify them at present, causing issues tracking which child model a comment is attached to across revisions.
Describe the solution you'd like
We should enable commenting on InlinePanels. This could be by either:
Allowing comment contentpaths to vary by revision, using the order of an InlinePanel as the identifying part of the contentpath for child models (so the contentpath would be relation_name.0 for the 0th instance), and updating it using the InlinePanel js when positions are changed. Downside: this is more fragile, especially when content is updated/reordered programatically.
Coming up with some unique identifier (such a a uuid) for child models that have not yet been saved to the database, and using that as the identifying part of the comment's contentpath
@SyedImtiyaz-1 feel free to read through this issue, the comments and related work.
However, I think this is not good first issue as it will take a lot of understanding of both the commenting system and the InlinePanel system. Both of which are quite complex.
Nonetheless, if you feel confident giving it a go - I suggest you get started on some ideas and write a comment when you are ready to present a proposed solution. Or a draft PR.
As noted on other issues, we do not really assign specific tasks outside of the core team.
If you haven't already, maybe introduce yourself in the Slack channel #new-contributors ping me and we can say hi and see how to get you started with a good first issue.
Is your proposal related to a problem?
When #9649 is merged, commenting on
InlinePanels
will be disabled. This is a feature that was never intended to be enabled without further development, so had a number of issues: child models that aren't yet saved to the database do not have a stable way to identify them at present, causing issues tracking which child model a comment is attached to across revisions.Describe the solution you'd like
We should enable commenting on
InlinePanels
. This could be by either:contentpaths
to vary by revision, using the order of anInlinePanel
as the identifying part of the contentpath for child models (so the contentpath would berelation_name.0
for the 0th instance), and updating it using theInlinePanel
js when positions are changed. Downside: this is more fragile, especially when content is updated/reordered programatically.Additional context
#9641
The text was updated successfully, but these errors were encountered: