Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable InlinePanel commenting #9685

Open
jacobtoppm opened this issue Nov 16, 2022 · 3 comments
Open

Enable InlinePanel commenting #9685

jacobtoppm opened this issue Nov 16, 2022 · 3 comments

Comments

@jacobtoppm
Copy link
Member

Is your proposal related to a problem?

When #9649 is merged, commenting on InlinePanels will be disabled. This is a feature that was never intended to be enabled without further development, so had a number of issues: child models that aren't yet saved to the database do not have a stable way to identify them at present, causing issues tracking which child model a comment is attached to across revisions.

Describe the solution you'd like

We should enable commenting on InlinePanels. This could be by either:

  • Allowing comment contentpaths to vary by revision, using the order of an InlinePanel as the identifying part of the contentpath for child models (so the contentpath would be relation_name.0 for the 0th instance), and updating it using the InlinePanel js when positions are changed. Downside: this is more fragile, especially when content is updated/reordered programatically.
  • Coming up with some unique identifier (such a a uuid) for child models that have not yet been saved to the database, and using that as the identifying part of the comment's contentpath

Additional context

#9641

@lb-
Copy link
Member

lb- commented Nov 16, 2022

A few thoughts

  • We could do a partial solution by only allowing comments on items already in the database (however, this would be super confusing for users)
  • We should, when re-enabling, either ensure we consider what will happen to comments already in the DB from when this feature used to work-(ish)

@SyedImtiyaz-1
Copy link

I'm interested in this issue. Please, assign me this issue.

@lb-
Copy link
Member

lb- commented Jan 15, 2023

@SyedImtiyaz-1 feel free to read through this issue, the comments and related work.

However, I think this is not good first issue as it will take a lot of understanding of both the commenting system and the InlinePanel system. Both of which are quite complex.

Nonetheless, if you feel confident giving it a go - I suggest you get started on some ideas and write a comment when you are ready to present a proposed solution. Or a draft PR.

As noted on other issues, we do not really assign specific tasks outside of the core team.

If you haven't already, maybe introduce yourself in the Slack channel #new-contributors ping me and we can say hi and see how to get you started with a good first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants