Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coffee-splash scene #97

Closed
wahn opened this issue May 23, 2019 · 1 comment
Closed

coffee-splash scene #97

wahn opened this issue May 23, 2019 · 1 comment
Assignees
@wahn
Labels
bug

Comments

@wahn
Copy link
Owner

wahn commented May 23, 2019 •
edited

The coffee-splash scene from here:

https://www.pbrt.org/scenes-v3.html

Renders like this for C++ (using just 8 pixelsamples):

f15-5

The Rust version looks like this:

pbrt_rust

Figure out why the coffee material does not pick up the brownish color ...
@wahn wahn self-assigned this Jun 27, 2019
@wahn wahn added the bug label Jun 27, 2019
wahn referenced this issue Jun 27, 2019
@wahn
Handle interaction with medium, even if no surface was hit.
eef3358
@wahn
Copy link
Owner Author

wahn commented Jun 27, 2019

Commit eef3358 resolves the issue:

pbrt

There is still a difference in the handle of the cup, but the main problem is solved. Closing the issue.

@wahn wahn closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wahn wahn

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wahn