Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Detekt linter #250

Open
zaerald opened this issue Oct 23, 2020 · 1 comment
Open

Integrate Detekt linter #250

zaerald opened this issue Oct 23, 2020 · 1 comment
Labels
type: chore Environment or non-critical issues

Comments

@zaerald
Copy link
Member

zaerald commented Oct 23, 2020

I was checking the intellij-platform-plugin-template, and saw a detekt linter in addition to ktlint. Do you think we can also integrate it with WMP @Unthrottled? This would be a part where we add missing goodies here in WMP based on the template repo.

https://github.com/JetBrains/intellij-platform-plugin-template/blob/e44bf3c3ec0d1fd1ac9e1f78bc5bda7eacb14257/build.gradle.kts#L15-L18

    // detekt linter - read more: https://detekt.github.io/detekt/gradle.html
    id("io.gitlab.arturbosch.detekt") version "1.14.2"
    // ktlint linter - read more: https://github.com/JLLeitschuh/ktlint-gradle
    id("org.jlleitschuh.gradle.ktlint") version "9.4.1"

Reference

@zaerald zaerald added type: chore Environment or non-critical issues for: discuss labels Oct 23, 2020
@Unthrottled
Copy link
Member

Unthrottled commented Oct 23, 2020

Yes! That would be nice!

Suggested extension to the detekt config

exceptions:
  TooGenericExceptionCaught:
    active: false

performance:
  SpreadOperator:
    active: false

style:
  ForbiddenComment:
    active: true
    values: []

empty-blocks:
  active: false

Would also like detekt to be configured to autocorrect as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Environment or non-critical issues
Projects
None yet
Development

No branches or pull requests

2 participants