Fix some bug on Windows #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If build is 32-bit and os is 64-bit, `has('win64')` will return `false`
```
if s:IsWindows()
let job_cmd = [&shell, &shellcmdflag] + cmd
```
Or will pop up the console window ErichDonGubler@4fb1c2c
There are also two lines that affect the slow start ≈ 1000ms (no fix):
* 104: system('uname -s')
* 108: system('uname -m')
alanhamlett
reviewed
Jan 1, 2022
| let s:home = expand("$HOME") | ||
| endif | ||
| if has('win32') |
There was a problem hiding this comment.
Would it hurt to always replace \ with /, even when not on Windows?
There was a problem hiding this comment.
Tested on Windows 11, Msys2 and WSL no problem.
alanhamlett
reviewed
Jan 1, 2022
| @@ -90,13 +95,16 @@ let s:VERSION = '9.0.1' | |||
| " Detect os and architecture | |||
| if s:IsWindows() | |||
| let s:osname = "windows" | |||
| if has("win64") | |||
| if has("win64") || isdirectory(expand('$WINDIR') . '\SysWOW64') | |||
There was a problem hiding this comment.
Let's be extra careful and do:
if has("win64") || exists('$WINDIR') && isdirectory(expand('$WINDIR') . '\SysWOW64')
There was a problem hiding this comment.
Ok. I don't know if there is any other better way to detect 64-bit.
alanhamlett
approved these changes
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.