Skip to content

Commit

Permalink
Remove EvaledJob. Implement your own if you need this functionality.
Browse files Browse the repository at this point in the history
  • Loading branch information
bkeepers committed Dec 19, 2009
1 parent 7a5c8f4 commit 56860e0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 27 deletions.
17 changes: 3 additions & 14 deletions lib/delayed/job.rb
Expand Up @@ -47,10 +47,9 @@ def payload_object=(object)
end

# Add a job to the queue
def self.enqueue(*args, &block)
object = block_given? ? EvaledJob.new(&block) : args.shift

unless object.respond_to?(:perform) || block_given?
def self.enqueue(*args)
object = args.shift
unless object.respond_to?(:perform)
raise ArgumentError, 'Cannot enqueue items which do not respond to perform'
end

Expand Down Expand Up @@ -151,14 +150,4 @@ def before_save
end

end

class EvaledJob
def initialize
@job = yield
end

def perform
eval(@job)
end
end
end
13 changes: 0 additions & 13 deletions spec/job_spec.rb
Expand Up @@ -43,19 +43,6 @@
Delayed::Job.first.run_at.should be_close(later, 1)
end

it "should work with eval jobs" do
$eval_job_ran = false

job = Delayed::Job.enqueue do <<-JOB
$eval_job_ran = true
JOB
end

job.invoke_job

$eval_job_ran.should == true
end

it "should work with jobs in modules" do
job = Delayed::Job.enqueue M::ModuleJob.new
lambda { job.invoke_job }.should change { M::ModuleJob.runs }.from(0).to(1)
Expand Down

0 comments on commit 56860e0

Please sign in to comment.