Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate import in rln-js #232

Open
weboko opened this issue Apr 25, 2023 · 4 comments
Open

chore: deprecate import in rln-js #232

weboko opened this issue Apr 25, 2023 · 4 comments

Comments

@weboko
Copy link
Contributor

weboko commented Apr 25, 2023

Idea is to remove import field for RLN credentials.

More details - #225 (comment)

@fryorcraken
Copy link
Collaborator

Might make sense to do waku-org/js-rln#48 first so that we can have 2 examples:

  1. Uses wallet signature to generate/retrieve credentials
  2. Uses import/export tool to manage credentials, this would enable user to use credentials across implementations

@fryorcraken
Copy link
Collaborator

fryorcraken commented Apr 27, 2023

Actually, being able to export credentials when they are created from a signature would be useful.

Currently, you have to pass your private key to nwaku to register in the RLN contract. This is not great as your private is seen clear text by your computer (shell history or config file).

Instead, one could be encouraged to use Web app to register in RLN contract, and then export the RLN credentials to use them with nwaku. Cc @rymnc, wdyt?


We are attempting 2 things with the examples:

  • PoCs
  • Examples for developers

Theses two goals are contradictory. First we should review how we want to use examples for Dev Rel. @fryorcraken to discuss with @hackyguru and @LordGhostX.

@rymnc
Copy link

rymnc commented Apr 27, 2023

Great idea. Please refer to the waku keystore to generate a valid keystore that can be accepted by nwaku - https://github.com/waku-org/nwaku/tree/master/waku/v2/waku_keystore

adapted from nimbus' keystore, should be some code you can reuse

@fryorcraken
Copy link
Collaborator

Tracking here the PoC vs examples discussion: #163 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

3 participants