You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
Race condition error appears during TestDiscV5WithCapabilitiesFilter test run. Problem is with (d *DiscoveryV5) SetBootnodes() call. It looks setting boot nodes after DiscoveryV5 instance was created interferes with discovery process already going on.
Have race condition treated or remove SetBootnodes() feature, as I saw it is not used and it is a bit counterintuitive.
I kind of agree with having SetBooNodes after starting discv5 may not be intutive, but wondering if this race condition actually causes any issues.
The read is done in a doRefresh method which seems to be called in a loop, so the bootNodes would be used in the next iteration of the loop and hence this should not cause any functional issue.
As @chaitanyaprem this race condition shouldn't cause issues as the values set on the table nursery table of discv5 will be read in next iteration, but just for the sake of not having this issue pop up in the CI, i'll protect the nursery attr with the mutex
Description
Race condition error appears during TestDiscV5WithCapabilitiesFilter test run. Problem is with (d *DiscoveryV5) SetBootnodes() call. It looks setting boot nodes after DiscoveryV5 instance was created interferes with discovery process already going on.
To Reproduce
Expected behavior
Have race condition treated or remove SetBootnodes() feature, as I saw it is not used and it is a bit counterintuitive.
Logs
The text was updated successfully, but these errors were encountered: