-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: dont harcode clusterid for autosharding #1061
Comments
Started this here #1063 thinking it would be simpler change, but it doesn't seem that straight-forward. We may not take it up if it involves lot of changes to the code and to the API's that would be used by Status. How important is it that this is needed in go-waku? |
From interop testing POV (nwaku -> go-waku) we are testing autosharding on other cluster IDs because ID 1 is used by TWN and enforces the use of RLN and we don't have support yet for RLN in our testing framework. |
I think this should be fine, because go-waku is anyways not being used for autosharding. Status is using go-waku with static-sharding only. And IIRC, all other users of go-waku use their own sharding. |
Will do that
Yes, we have such tests |
I mean, there is way to hack around to handle the complications. But don't want to do that unless absolutely necessary. |
As explained here, this need not be fixed in go-waku. |
I see that all content topics are resolving to cluster id = 1 because this hardcoding
Maybe we can remove it like it was removed on nwaku and js-waku
The text was updated successfully, but these errors were encountered: