Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: update examples to use autosharding #846

Closed
richard-ramos opened this issue Oct 27, 2023 · 1 comment · Fixed by #986
Closed

bug: update examples to use autosharding #846

richard-ramos opened this issue Oct 27, 2023 · 1 comment · Fixed by #986
Assignees
@chaitanyaprem
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@richard-ramos
Copy link
Member

While working on #845 I noticed that the examples weren't working correctly because the subscription nor the publish specified the pubsub topic. So a mix of using autosharding and named sharding was happening.

I 'fixed' it by using the default pubsub topic, but we should update the examples to use autosharding
@richard-ramos richard-ramos mentioned this issue Oct 27, 2023
Merged
4 tasks
@chaitanyaprem chaitanyaprem self-assigned this Nov 3, 2023
@chair28980 chair28980 added bug Something isn't working documentation Improvements or additions to documentation labels Jan 2, 2024
@chaitanyaprem chaitanyaprem mentioned this issue Jan 3, 2024
Merged
@chaitanyaprem chaitanyaprem linked a pull request Jan 3, 2024 that will close this issue
chore: update examples with autosharding and static sharding #986
Merged
@chaitanyaprem
Copy link
Collaborator

Weekly Update

  • achieved: update basic_relay example to use static and autosharding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaitanyaprem chaitanyaprem

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update examples with autosharding and static sharding waku-org/go-waku
3 participants
@richard-ramos @chaitanyaprem @chair28980