Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discv5): filter peer by capability #863

Closed
1 task done
chaitanyaprem opened this issue Nov 3, 2023 · 1 comment
Closed
1 task done

feat(discv5): filter peer by capability #863

chaitanyaprem opened this issue Nov 3, 2023 · 1 comment
Assignees
@chaitanyaprem
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented Nov 3, 2023 •
edited

Problem

Discv5 filtering doesn't follow the RFC and filter ENR caps.
Refer waku-org/nwaku#2179

Suggested solution

Add to the filtering a check for empty caps.

Follow the RFC https://rfc.vac.dev/spec/31/#usage-1

Acceptance criteria

  • Peers discovered with ENR missing the waku2 field or no capability set must be filtered out.
@chaitanyaprem chaitanyaprem self-assigned this Nov 3, 2023
@chaitanyaprem chaitanyaprem added the E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details label Nov 3, 2023
@chaitanyaprem chaitanyaprem mentioned this issue Nov 6, 2023
Merged
2 tasks
@chaitanyaprem
Copy link
Collaborator Author

Weekly Update

  • achieved: added capacility in discv5 to filter out peers that do not have waku2 ENR field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaitanyaprem chaitanyaprem

Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chaitanyaprem