Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(filter v2): unsubscribe all with unrelated peer #933

Closed
romanzac opened this issue Nov 29, 2023 · 2 comments
Closed

chore(filter v2): unsubscribe all with unrelated peer #933

romanzac opened this issue Nov 29, 2023 · 2 comments
Assignees

Comments

@romanzac
Copy link
Collaborator

Background

After the call of unsubscribe all with unrelated peer, no error is returned to tell developer unsubscribe had no effect.

Details

I wish developer (integrator) could receive error sub message under "could not unsubscribe from peer" with reason describing this peer is unrelated or unsubscribed.

Acceptance criteria

Error is returned to clarify the situation. Existing test "TestUnsubscribeAllUnrelatedPeer" will pass.

@chaitanyaprem
Copy link
Collaborator

@romanzac fixed the underlying error in referenced PR, you can modify your test before merging and then close this issue.

@chaitanyaprem chaitanyaprem removed their assignment Dec 1, 2023
@romanzac
Copy link
Collaborator Author

romanzac commented Dec 1, 2023

Thanks a lot.

@romanzac romanzac closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants