feat: re-work rln-js #281
Merged
feat: re-work rln-js #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
There was a problem hiding this comment.
did a first pass, some suggestions:
- delete
next.svgandvercel.svgthat come with the default setup - use tailwindcss classes directly instead of creating straightforward components like
Title,Subtitle- components like
Buttoncan remain - rename the
Blockchaincomponent to something more verbose specific to the app likeAccountInfo
- components like
weboko
requested review from
danisharora099,
fryorcraken and
a team
and removed request for
fryorcraken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I re-created rln-js with Next.js.
Resolves - #279
Choice for Next.js was because many hackers were using it and it is one of the platforms that fails during development on some of waku errors so I had to investigate it for waku-org/js-waku#1665
This APP supports latest
@waku/rlnAPI and addresses some fixes.Structure of this example can be re-used later for templates.
UI now looks like
