You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now @waku/* projects more or less follow the same testing stack/approach:
mocha, karma, chai for the stack;
run tests in headless Chrome;
Proposed Solutions
I think it is better for us to move to jest due to various factors:
all-in-one lib (no need to configure additionally if something is needed such as spy lib);
seamless local experience;
easy to configure browser like environment;
configurable with puppeteer;
Notes
One of the features I'd like to unlock by introducing jest is opportunity to test in different browsers. In case of Chrome there are no problems, but if Firefox or some other browser is our goal - we will have to choose automated testing approach and use Cypress or similar solution such as Browser Stack.
Before going deep into integrating testing with other browsers I'd like to take a step back and point out goals of it:
make sure library is interpretable by different browsers;
library is run the same way in different browsers;
I think that we can cover those cases in a good enough way by:
defining list of supported browsers;
using polyfills;
setting build system in a way it targets supported browsers;
running tests in a browser like (or Chrome) environment;
This list is based on the fact that we are speaking about JS library and assumption that the only thing that can work differently within various browsers is API used and not transformed properly (no polyfill e.g).
I don't think any of the current stack use polyfills.
make sure library is interpretable by different browsers;
It's possible to do with Karma
Right now @waku/* projects more or less follow the same testing stack/approach:
mocha, karma, chai for the stack;
run tests in headless Chrome;
The problem statement seems to be more a description of the current stack. Could you be more specific on the gains we would have in migrating to jest? I expect the migration to be costly and hence I just want to ensure we have a high ROI for this change.
This is a change request
Problem
Right now
@waku/*
projects more or less follow the same testing stack/approach:Proposed Solutions
I think it is better for us to move to jest due to various factors:
Notes
One of the features I'd like to unlock by introducing
jest
is opportunity to test in different browsers. In case of Chrome there are no problems, but if Firefox or some other browser is our goal - we will have to choose automated testing approach and use Cypress or similar solution such as Browser Stack.Before going deep into integrating testing with other browsers I'd like to take a step back and point out goals of it:
I think that we can cover those cases in a good enough way by:
This list is based on the fact that we are speaking about JS library and assumption that the only thing that can work differently within various browsers is API used and not transformed properly (no polyfill e.g).
Related PRs: waku-org/js-rln#45
cc: @fryorcraken
The text was updated successfully, but these errors were encountered: