Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release process to make releases for commits #1543

Closed
danisharora099 opened this issue Sep 7, 2023 · 11 comments · Fixed by #1664
Closed

update release process to make releases for commits #1543

danisharora099 opened this issue Sep 7, 2023 · 11 comments · Fixed by #1664
Assignees
Labels
infra Infra, devops, CI and related tasks

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Sep 7, 2023

Problem

We currently make releases for the master HEAD every month. This introduces delays to test the functionality as we need to do a release to use the new HEAD.

Proposed Solutions

The proposal is to release commits that are merged to master tagged with their commit hash or even make nightly releases perhaps.
This allows consumers (and us) to be able to test these functionalities outside of the scope of js-waku with ease.

Notes

While some solutions like building js-waku locally and using the build files directly are still possible, they are not as frictionless of a process.

@danisharora099
Copy link
Collaborator Author

danisharora099 commented Sep 7, 2023

@danisharora099 to update the issue to instead have tagged releases for master commits

--
update: issue has been updated to reflect the decided end goal

@danisharora099 danisharora099 changed the title introduce a new branch unstable as proxy master update release process to make releases for commits Sep 7, 2023
@danisharora099
Copy link
Collaborator Author

something that's quite nice with nwaku release process: waku-org/nwaku#2006 (comment)

@weboko
Copy link
Collaborator

weboko commented Sep 8, 2023

next step:

  • add beta or next release from the master on each commit;

@danisharora099 why is it a priority?

@danisharora099
Copy link
Collaborator Author

next step:

  • add beta or next release from the master on each commit;

@danisharora099 why is it a priority?

not a priority, but we put it there as it should be a fairly less time consuming task iirc

@danisharora099
Copy link
Collaborator Author

danisharora099 commented Oct 11, 2023

@weboko moving this to priority to enable testing unreleased, but merged, code in examples in a way which does not take too much time or friction and as I understand should not take too much time. I'm happy to take this up

@weboko
Copy link
Collaborator

weboko commented Oct 14, 2023

I agree it should be done rather early, should be useful

@weboko
Copy link
Collaborator

weboko commented Oct 14, 2023

TODO:

  • add CI script & version bump;
  • need to write script to bump versions of @waku/* dependencies to RC version

@fryorcraken fryorcraken added the infra Infra, devops, CI and related tasks label Oct 30, 2023
@fryorcraken
Copy link
Collaborator

I'd suggest to make PR for merged PRs, not all commits.

@weboko
Copy link
Collaborator

weboko commented Oct 30, 2023

@fryorcraken do you mean similarly how release-please is working?
It creates PR after merging which release happens.

@fryorcraken
Copy link
Collaborator

@fryorcraken do you mean similarly how release-please is working? It creates PR after merging which release happens.

My input was just to release for specific PR merge commit I guess. not every commit of the feature branch.

@weboko
Copy link
Collaborator

weboko commented Nov 3, 2023

Addressing it here #1702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra, devops, CI and related tasks
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants