Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: message hash does not match the spec #1982

Closed
vpavlin opened this issue Apr 25, 2024 · 1 comment
Closed

bug: message hash does not match the spec #1982

vpavlin opened this issue Apr 25, 2024 · 1 comment
Assignees
@danisharora099
Labels
bug Something isn't working

Comments

@vpavlin
Copy link
Member

vpavlin commented Apr 25, 2024

This is a bug report

Problem

The message hash package (https://github.com/waku-org/js-waku/blob/master/packages/message-hash/src/index.ts) does not match the spec https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/14/message.md#deterministic-message-hashing - the timestamp is not included in the hash

Proposed Solutions

include timestamp

Notes
@weboko weboko changed the title message hash does not match the spec bug: message hash does not match the spec Apr 26, 2024
@weboko weboko added the bug Something isn't working label Apr 26, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 26, 2024

Will be resolved in #1985

@weboko weboko closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danisharora099 danisharora099

Labels
bug Something isn't working
Projects
Waku
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vpavlin @danisharora099 @weboko