-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support RateLimitProof
and Ephemeral
attributes in wakunode2 JSON-RPC/REST APIs
#1214
Comments
I believe there was some conversation around skipping the ephemeral flag in RPC/REST responses due to the nature of it being only of interest to peers and not to the end user. cc: @jm-clius wdyt? |
Eh, yeah, I think we have some inconsistencies here:
|
One question, is this a bug? Or a missing feature and, therefore, a feature request? For me, a bug 🐛 is:
For example, the waku store response's next page's info contains an empty cursor when it should be returning a valid cursor. Suppose a behavior is not described as part of the feature's specification and is not present in the implementation. In that case, we are discussing either a defect (if it makes the functionality unusable) or a feature enhancement/improvement request. |
I admit that I did not spend much time thinking which category to use with this issue. Let's change it to whatever makes more sense! |
RateLimitProof
and Ephemeral
attributesRateLimitProof
and Ephemeral
attributes in wakunode2 JSON-RPC/REST APIs
No description provided.
The text was updated successfully, but these errors were encountered: