Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support RateLimitProof and Ephemeral attributes in wakunode2 JSON-RPC/REST APIs #1214

Open
richard-ramos opened this issue Oct 2, 2022 · 4 comments
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details

Comments

@richard-ramos
Copy link
Member

No description provided.

@richard-ramos richard-ramos added bug Something isn't working track:maintenance labels Oct 2, 2022
@rymnc
Copy link
Contributor

rymnc commented Oct 3, 2022

I believe there was some conversation around skipping the ephemeral flag in RPC/REST responses due to the nature of it being only of interest to peers and not to the end user.

cc: @jm-clius wdyt?

@jm-clius
Copy link
Contributor

jm-clius commented Oct 3, 2022

Eh, yeah, I think we have some inconsistencies here:

  • RateLimitProof is not yet added to 14/WAKU2-MESSAGE and probably shouldn't be as we want to move this spec to stable very soon. If this is necessary/useful on the APIs, we can/should add it.
  • There was some discussion on the value of ephemeral on the APIs. Currently it will be returned in responses on the JSON-RPC API but is not available when posting messages or on the REST API. I think the simplest thing is just to add this field to both APIs. @rymnc

@LNSD
Copy link
Contributor

LNSD commented Oct 3, 2022

One question, is this a bug? Or a missing feature and, therefore, a feature request?

For me, a bug 🐛 is:

A feature implementation that is not working as per its specification.

For example, the waku store response's next page's info contains an empty cursor when it should be returning a valid cursor.

Suppose a behavior is not described as part of the feature's specification and is not present in the implementation. In that case, we are discussing either a defect (if it makes the functionality unusable) or a feature enhancement/improvement request.

@richard-ramos
Copy link
Member Author

I admit that I did not spend much time thinking which category to use with this issue. Let's change it to whatever makes more sense!

@LNSD LNSD changed the title bug: RPC and REST WakuMessages are not including the RateLimitProof and Ephemeral attributes feat: support RateLimitProof and Ephemeral attributes in wakunode2 JSON-RPC/REST APIs Oct 3, 2022
@LNSD LNSD added track:production and removed bug Something isn't working track:maintenance labels Oct 3, 2022
@fryorcraken fryorcraken added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details
Projects
Status: Icebox
Development

No branches or pull requests

5 participants