Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable TcpNoDelay #1470

Merged
merged 3 commits into from
Jul 15, 2023
Merged

feat: Enable TcpNoDelay #1470

merged 3 commits into from
Jul 15, 2023

Conversation

Menduist
Copy link
Contributor

@Menduist Menduist commented Dec 16, 2022

Improves networking performance by avoiding up to 40ms useless delay in some cases

ref vacp2p/nim-libp2p#822

@status-im-auto
Copy link
Collaborator

status-im-auto commented Dec 16, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e2a0c75 #1 2022-12-16 23:01:21 ~14 min macos 📦bin
e2a0c75 #1 2023-01-24 10:08:27 ~19 min linux 📄log

@Menduist
Copy link
Contributor Author

Menduist commented Jul 4, 2023

This is now enabled by default in libp2p

@Menduist Menduist closed this Jul 4, 2023
@Menduist
Copy link
Contributor Author

Menduist commented Jul 4, 2023

Oh, actually not, nevermind

@Menduist Menduist reopened this Jul 4, 2023
@Menduist Menduist changed the title Enable TcpNoDelay feat: Enable TcpNoDelay Jul 4, 2023
@Menduist Menduist marked this pull request as ready for review July 4, 2023 14:28
@Menduist Menduist closed this Jul 4, 2023
@Menduist Menduist reopened this Jul 4, 2023
@jm-clius jm-clius merged commit 08f3bba into master Jul 15, 2023
15 checks passed
@jm-clius jm-clius deleted the tcpnodelay branch July 15, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants