bug: fix hash size greater than 32 #1621
Conversation
waku/v2/node/waku_node.nim
Outdated
| @@ -392,10 +392,11 @@ proc registerRelayDefaultHandler(node: WakuNode, topic: PubsubTopic) = | |||
| return | |||
|
|
|||
| proc traceHandler(topic: PubsubTopic, data: seq[byte]) {.async, gcsafe.} = | |||
| let mh = MultiHash.digest("sha2-256", data).expect("valid hash") | |||
There was a problem hiding this comment.
Is there any requirement for using multihash here? Why don't we use the std/hash sha256 function directly? That would simplify things.
There was a problem hiding this comment.
agree, @jm-clius ?
There was a problem hiding this comment.
Yes, good catch - we should use only sha256. We used Multihash before to mimic what we used in the messageIdProvider, but that has also since changed to pure sha256 to match with go-waku.
There was a problem hiding this comment.
btw can we use digest from digest*(pubsubTopic: PubsubTopic, msg: WakuMessage): WakuMessageDigest =? or what is stopping is from using it?
There was a problem hiding this comment.
Afaics we can use it (provided we change the tracehandler to take the WakuMessage so that we don't decode twice). This was originally over the whole message in order to mimic what we do for message IDs in gossipsub, but now that we have specified what deterministic hashing should look like it's probably a good idea to use that specified hash (i.e. the digest).
alrevuelta
force-pushed
the
fix-log-hash
branch
from
b7a670a
to
5b14cfb
Compare
|
using now digest as suggested :) |
waku/v2/node/waku_node.nim
Outdated
| trace "waku.relay received", | ||
| peerId=node.peerId, | ||
| pubsubTopic=topic, | ||
| hash=MultiHash.digest("sha2-256", data).expect("valid hash").data.buffer.to0xHex(), # TODO: this could be replaced by a message UID | ||
| hash="0x" & $topic.digest(msg).toHex(), |
There was a problem hiding this comment.
A minor request. There is a to0xHex() proc in stew/byteutils. Could you replace the string concat here with that method?
There was a problem hiding this comment.
sure! fair request. done
e41d042
digestto calculate the message hash when logging it.