chore: do not mount relay more than once

[alrevuelta]

• Prevents the relay from being mounted more than once.
• This prevents mounting more relay protocols in the switch, which created unnecessary streams under the hood.

[jm-clius]

From the issue description, it seems like this was a real problem noticed somewhere? I guess I'd first need to understand why mountRelay was called twice in the first place so we can prevent that? Or was this only in a test environment? Afaict this shouldn't be able to happen on any of our apps. If this is just a sanity check or to prevent node.mountRelay being called twice in new apps/tests, it MSTM.

[LNSD]

LGTM ✅

[alrevuelta]

@jm-clius I found this issue while testing, but i think its a nice to have due to the implications it has.

what do you mean by MSTM? can't find it online.

[jm-clius]

but i think its a nice to have due to the implications it has

Indeed. I was just worried that there may be some bug in wakunode2 that causes relay to be mounted twice, which would be unexplained behaviour. It makes sense as a safety check.

Oh, MSTM = Makes Sense To Me. I thought it was used more widely, but I also now can't find it. 😄

Approving.