Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wakunode2): flatten and simplify app setup #1705

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Apr 26, 2023

There was one last task pending from the wakunode2 app refactoring:

  • Flattened and simplified the RPC and REST APIs setup code.
  • Made the nim-metrics server stoppable.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LNSD LNSD force-pushed the refactor-wakunode2-app-setup-apis branch from 5c5ceec to afe736c Compare April 26, 2023 16:44
@LNSD LNSD merged commit ce92fc1 into master Apr 26, 2023
12 checks passed
@LNSD LNSD deleted the refactor-wakunode2-app-setup-apis branch April 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants