Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use QUICK_AND_DIRTY_COMPILER flag for CI #1708

Merged
merged 1 commit into from
May 2, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Apr 28, 2023

Description

Nimbus uses QUICK_AND_DIRTY_COMPILER flag in their ci and release actions. This skips some verification checks for Nim correctness , hence speeds up the build process see for actual usage in build_nim.sh - https://github.com/status-im/nimbus-build-system/blob/master/scripts/build_nim.sh#L185

Changes

  • enable the QUICK_AND_DIRTY_COMPILER for all CI jobs

@vpavlin vpavlin changed the title refactor: use QUICK_AND_DIRTY_COMPILER flag for CI rWIP: efactor: use QUICK_AND_DIRTY_COMPILER flag for CI Apr 28, 2023
@vpavlin vpavlin changed the title rWIP: efactor: use QUICK_AND_DIRTY_COMPILER flag for CI WIP: refactor: use QUICK_AND_DIRTY_COMPILER flag for CI Apr 28, 2023
@vpavlin vpavlin changed the title WIP: refactor: use QUICK_AND_DIRTY_COMPILER flag for CI refactor: use QUICK_AND_DIRTY_COMPILER flag for CI Apr 28, 2023
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@vpavlin vpavlin merged commit 2151042 into master May 2, 2023
14 of 15 checks passed
@vpavlin vpavlin deleted the feat/dirty-compiler branch May 2, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants